Fixing problem with saving birthday #274
Conversation
| try{ | ||
| profile.birthday = (Date) birthday_formatting.parse(birthday); | ||
| } catch (java.text.ParseException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
you need to do something proper on the exception. It is very important to handle it well. We don't want to show the user the exception trace. Handle it, show a proper message to the user.
|
What's up? |
|
Does this now look better for the error messages? |
|
No. Look how errors are handled here: |
|
Also look at the signup page and how errors are handled there, |
|
Right, the validation. I'm still working on the regex and testing because I am using validation.match to handle user input errors for calendar related fields. |
|
As soon as you send an update I will review and merge it. Make sure you pull first. |
|
Okay I moved the error messages to display all of them at the top of the left panel in red and tested to see if saving still works. |
|
Just a heads up, I fixed some other things as well |
|
let me test it |
Fixing problem with saving birthday
Should be able to save birthdays for different users. #163
Added cancel button to each of the sections in the edit profile page. #165
Added default birthday values to upcoming dates for Alice and Jeff in initial data #273
Able to save Interested in field now #163
Added more internationalisation (i18n) to profile html file #147
Able to save relationship status now #163